farmcontrol/farmcontrol-ui
farmcontrol/farmcontrol-ui
2
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor NotificationContext to simplify notification fetching logic by removing redundant useEffect. Update condition checks for authenticated and notificationCenterVisible to use strict equality.
All checks were successful
farmcontrol/farmcontrol-ui/pipeline/head This commit looks good
Details

Browse Source
This commit is contained in:
Tom Butcher 2026-03-07 20:32:11 +00:00
parent 52fd0ebd63
commit 04d26600fd
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/Dashboard/context/NotificationContext.jsx
View File

@ -113,17 +113,11 @@ const NotificationProvider = ({ children }) => {
const unreadCount = notifications.filter((n) => !n.read).length const unreadCount = notifications.filter((n) => !n.read).length
useEffect(() => { useEffect(() => {
if (authenticated && notificationCenterVisible) { if (authenticated == true && notificationCenterVisible == true) {
fetchNotifications() fetchNotifications()
} }
}, [authenticated, notificationCenterVisible, fetchNotifications]) }, [authenticated, notificationCenterVisible, fetchNotifications])
useEffect(() => {
if (authenticated) {
fetchNotifications()
}
}, [authenticated, fetchNotifications])
useEffect(() => { useEffect(() => {
setNotificationCenterVisible(false) setNotificationCenterVisible(false)
}, [location.pathname]) }, [location.pathname])