From 451787debd016c824328a34dc65028be29e83645 Mon Sep 17 00:00:00 2001
From: Tom Butcher <thomasbutcher15@gmail.com>
Date: Tue, 1 Sep 2026 19:55:23 +0100
Subject: [PATCH] Refactor SimplePropertyFilter to Move MissingPlaceholder
 Logic

- Moved the MissingPlaceholder component logic to a new position within the SimplePropertyFilter component for improved readability and structure.
- Ensured that the component correctly displays a message when no options are found while maintaining the loading state functionality.
---
 .../Dashboard/common/SimplePropertyFilter.jsx | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/components/Dashboard/common/SimplePropertyFilter.jsx b/src/components/Dashboard/common/SimplePropertyFilter.jsx
index d6e9e729..ad9cdcf9 100644
--- a/src/components/Dashboard/common/SimplePropertyFilter.jsx
+++ b/src/components/Dashboard/common/SimplePropertyFilter.jsx
@@ -270,17 +270,6 @@ const SimplePropertyFilter = ({
     emitChange([...hiddenSelected, ...visibleCheckedKeys])
   }
 
-  if (!loading && options.length === 0) {
-    return (
-      <MissingPlaceholder
-        message='No options found.'
-        hasBackground={false}
-        hasBorder={false}
-        padding='0'
-      />
-    )
-  }
-
   if (isDateTimeProperty(property)) {
     return (
       <SimpleDateTimePropertyFilter
@@ -296,6 +285,17 @@ const SimplePropertyFilter = ({
     )
   }
 
+  if (!loading && options.length === 0) {
+    return (
+      <MissingPlaceholder
+        message='No options found.'
+        hasBackground={false}
+        hasBorder={false}
+        padding='0'
+      />
+    )
+  }
+
   return (
     <Spin spinning={loading} indicator={<LoadingOutlined spin />}>
       <Checkbox.Group