Refactor AlertsDisplay component to accept dynamic object and type props

- Updated AlertsDisplay to receive an object and its type instead of specific alerts and printerId, enhancing reusability for different object types.
- Modified ControlPrinter and ObjectProperty components to pass the new props structure, ensuring consistent alert handling across various contexts.
This commit is contained in:
Tom Butcher 2026-07-26 21:11:15 +01:00
parent e730e2c832
commit 5e19b6c9b0
3 changed files with 75 additions and 36 deletions

View File

@ -278,8 +278,8 @@ const ControlPrinter = ({ slicerIntegration = false }) => {
</Flex> </Flex>
<AlertsDisplay <AlertsDisplay
alerts={objectFormState.objectData?.alerts} object={objectFormState.objectData}
printerId={printerId} objectType='printer'
/> />
<ScrollBox> <ScrollBox>

View File

@ -1,27 +1,36 @@
import PropTypes from 'prop-types' import PropTypes from 'prop-types'
import { createElement } from 'react' import { createElement, useContext } from 'react'
import { Flex, Alert, Button, Dropdown } from 'antd' import { Flex, Alert, Button, Dropdown } from 'antd'
import ExclamationOctagonIcon from '../../Icons/ExclamationOctagonIcon' import ExclamationOctagonIcon from '../../Icons/ExclamationOctagonIcon'
import InfoCircleIcon from '../../Icons/InfoCircleIcon' import InfoCircleIcon from '../../Icons/InfoCircleIcon'
import { CaretDownOutlined } from '@ant-design/icons' import XMarkIcon from '../../Icons/XMarkIcon'
import { getModelByName } from '../../../database/ObjectModels' import { getModelByName } from '../../../database/ObjectModels'
import { useNavigate } from 'react-router-dom' import { useNavigate } from 'react-router-dom'
import ActionsIcon from '../../Icons/ActionsIcon'
import { ApiServerContext } from '../context/ApiServerContext'
const AlertsDisplay = ({ const AlertsDisplay = ({
alerts = [], object,
printerId, objectType,
showDismiss = true, showDismiss = true,
showActions = true showActions = true
}) => { }) => {
const alerts = object?.alerts ?? []
const objectId = object?._id
const getAlertType = (type, priority) => { const getAlertType = (type, priority) => {
if (type === 'error' || priority === '9') return 'error' if (type === 'error' || priority === '9') return 'error'
if (type === 'warning' || priority === '8') return 'warning' if (type === 'warning' || priority === '8') return 'warning'
return 'info' return 'info'
} }
const printerModel = getModelByName('printer') const model = objectType ? getModelByName(objectType) : null
const navigate = useNavigate() const navigate = useNavigate()
const { updateObject } = useContext(ApiServerContext)
const handleDismissAlert = (alertId) => {
const updatedAlerts = alerts.filter((a) => a._id !== alertId)
updateObject(objectId, objectType, { alerts: updatedAlerts })
}
const getAlertIcon = (type, priority) => { const getAlertIcon = (type, priority) => {
if (type === 'error' || priority === '9') return <ExclamationOctagonIcon /> if (type === 'error' || priority === '9') return <ExclamationOctagonIcon />
if (type === 'warning' || priority === '8') if (type === 'warning' || priority === '8')
@ -103,7 +112,7 @@ const AlertsDisplay = ({
} }
const alertElements = alerts.map((alert, index) => { const alertElements = alerts.map((alert, index) => {
const printerActions = printerModel?.actions || [] const objectActions = model?.actions || []
const alertActionKeys = Array.isArray(alert?.actions) const alertActionKeys = Array.isArray(alert?.actions)
? alert.actions ? alert.actions
@ -116,7 +125,7 @@ const AlertsDisplay = ({
: [] : []
const allowedKeys = new Set(alertActionKeys) const allowedKeys = new Set(alertActionKeys)
const filteredActions = filterActionsByKeys(printerActions, allowedKeys) const filteredActions = filterActionsByKeys(objectActions, allowedKeys)
const findActionByKey = (actions, key) => { const findActionByKey = (actions, key) => {
if (!Array.isArray(actions)) return null if (!Array.isArray(actions)) return null
@ -144,7 +153,7 @@ const AlertsDisplay = ({
const action = findActionByKey(filteredActions, key) const action = findActionByKey(filteredActions, key)
if (action?.url) { if (action?.url) {
navigate(action.url(printerId)) navigate(action.url(objectId))
} else { } else {
console.warn('No action found for key:', key) console.warn('No action found for key:', key)
} }
@ -155,20 +164,46 @@ const AlertsDisplay = ({
<Alert <Alert
key={`${alert.createdAt}-${index}-${alert._id}`} key={`${alert.createdAt}-${index}-${alert._id}`}
message={alert.message} message={alert.message}
style={{ padding: '4px 10px 4px 8px' }} style={{ padding: '4px 5px 4px 10px', minHeight: '35px' }}
type={getAlertType(alert.type, alert.priority)} type={getAlertType(alert.type, alert.priority)}
icon={getAlertIcon(alert.type, alert.priority)} icon={getAlertIcon(alert.type, alert.priority)}
showIcon showIcon
closable={showDismiss && alert.canDismiss} closable={false}
onClose={() => {}} onClose={() => {}}
action={ action={
showActions ? ( <Flex gap='1px'>
<Dropdown menu={menu} on> {showActions && filteredActions.length >= 0 && (
<Button size='small' type='text' style={{ marginLeft: '5px' }}> <Dropdown menu={menu} on>
<CaretDownOutlined /> <Button
</Button> size='small'
</Dropdown> type='text'
) : null style={{ marginLeft: '5px' }}
icon={
<ActionsIcon
style={{ fontSize: '12px', marginBottom: '3.5px' }}
/>
}
/>
</Dropdown>
)}
{showDismiss && alert.canDismiss && (
<Button
size='small'
type='text'
style={{ marginLeft: '5px' }}
onClick={() => handleDismissAlert(alert._id)}
icon={
<XMarkIcon
style={{
fontSize: '10px',
marginBottom: '5px',
marginLeft: '0.5px'
}}
/>
}
/>
)}
</Flex>
} }
/> />
) )
@ -182,20 +217,24 @@ const AlertsDisplay = ({
} }
AlertsDisplay.propTypes = { AlertsDisplay.propTypes = {
printerId: PropTypes.string.isRequired, object: PropTypes.shape({
showActions: PropTypes.bool.isRequired, _id: PropTypes.string.isRequired,
showDismiss: PropTypes.bool.isRequired, alerts: PropTypes.arrayOf(
alerts: PropTypes.arrayOf( PropTypes.shape({
PropTypes.shape({ canDismiss: PropTypes.bool.isRequired,
canDismiss: PropTypes.bool.isRequired, _id: PropTypes.string.isRequired,
_id: PropTypes.string.isRequired, code: PropTypes.string,
type: PropTypes.string.isRequired, type: PropTypes.string.isRequired,
createdAt: PropTypes.string.isRequired, createdAt: PropTypes.string.isRequired,
updatedAt: PropTypes.string.isRequired, updatedAt: PropTypes.string.isRequired,
message: PropTypes.string, message: PropTypes.string,
actions: PropTypes.arrayOf(PropTypes.string) actions: PropTypes.arrayOf(PropTypes.string)
}) })
).isRequired )
}).isRequired,
objectType: PropTypes.string.isRequired,
showActions: PropTypes.bool,
showDismiss: PropTypes.bool
} }
export default AlertsDisplay export default AlertsDisplay

View File

@ -553,8 +553,8 @@ const ObjectProperty = ({
if (value != null && value?.length != 0) { if (value != null && value?.length != 0) {
return ( return (
<AlertsDisplay <AlertsDisplay
alerts={value} object={objectData}
printerId={objectData._id} objectType={objectType}
showDismiss={false} showDismiss={false}
showActions={false} showActions={false}
/> />