From aaeeb4013eb6e379d1e40ac0b62c72577c34299c Mon Sep 17 00:00:00 2001 From: Tom Butcher Date: Mon, 8 Dec 2025 22:59:35 +0000 Subject: [PATCH] Fixed infinite loop --- src/components/Dashboard/common/ObjectSelect.jsx | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/components/Dashboard/common/ObjectSelect.jsx b/src/components/Dashboard/common/ObjectSelect.jsx index a996507..375ed4e 100644 --- a/src/components/Dashboard/common/ObjectSelect.jsx +++ b/src/components/Dashboard/common/ObjectSelect.jsx @@ -354,14 +354,14 @@ const ObjectSelect = ({ value && typeof value === 'object' && value !== null && - valueRef.current !== value && + getValueIdentity(valueRef.current) !== getValueIdentity(value) && type != 'unknown' ) { - console.log('fetching full object', value) + // console.log('fetching full object', value) valueRef.current = value // Check if value is a minimal object and fetch full object if needed const fullValue = await fetchFullObjectIfNeeded(value) - console.log('fullValue', fullValue) + // console.log('fullValue', fullValue) // Build a new filter from value's properties that are in the properties list const valueFilter = { ...filter } properties.forEach((prop) => { @@ -384,7 +384,7 @@ const ObjectSelect = ({ }) // Fetch with the new filter handleFetchObjectsProperties(valueFilter) - console.log('setting treeSelectValue', valueRef.current._id) + // console.log('setting treeSelectValue', valueRef.current._id) setTreeSelectValue(valueRef.current._id) setInitialized(true) return @@ -420,13 +420,14 @@ const ObjectSelect = ({ token, fetchFullObjectIfNeeded, type, - connected + connected, + getValueIdentity ]) const prevValuesRef = useRef({ type, masterFilter }) useEffect(() => { - console.log('treeSelectValue', treeSelectValue) + // console.log('treeSelectValue', treeSelectValue) }, [treeSelectValue]) useEffect(() => {