Compare commits

...

2 Commits

Author SHA1 Message Date
3f9da22b58 Minor performance improvements.
All checks were successful
farmcontrol/farmcontrol-ui/pipeline/head This commit looks good
2026-03-13 19:47:26 +00:00
88674f0d6e Fixed update bug causing pointless http calls. 2026-03-13 19:40:14 +00:00
4 changed files with 36 additions and 26 deletions

View File

@ -1,5 +1,5 @@
import PropTypes from 'prop-types'
import { useState, useEffect, useContext } from 'react'
import { useState, useEffect, useContext, useCallback, useMemo, useRef } from 'react'
// import { getModelByName } from '../../../database/ObjectModels'
import DocumentPrinterIcon from '../../Icons/DocumentPrinterIcon'
import { Button, Dropdown, Modal } from 'antd'
@ -15,6 +15,9 @@ const DocumentPrintButton = ({
...buttonProps
}) => {
const { fetchObjects } = useContext(ApiServerContext)
const fetchObjectsRef = useRef(fetchObjects)
fetchObjectsRef.current = fetchObjects
const [documentTemplates, setDocumentTemplates] = useState([])
const [currentDocumentTemplate, setCurrentDocumentTemplate] = useState(null)
const [loading, setLoading] = useState(false)
@ -25,34 +28,40 @@ const DocumentPrintButton = ({
// Get the model by name
//const model = getModelByName(type)
// Fetch document templates when component mounts or type changes
useEffect(() => {
const loadDocumentTemplates = async () => {
if (!type || token == null) return
const loadDocumentTemplates = useCallback(async () => {
if (!type || token == null) return
setLoading(true)
try {
const result = await fetchObjects('documentTemplate', {
filter: {
objectType: type,
global: false,
active: true
},
limit: 100 // Get more templates to show in dropdown
})
setLoading(true)
try {
const result = await fetchObjectsRef.current('documentTemplate', {
filter: {
objectType: type,
global: false,
active: true
},
limit: 100 // Get more templates to show in dropdown
})
if (result && result.data) {
setDocumentTemplates(result.data)
}
} catch (error) {
console.error('Error fetching document templates:', error)
} finally {
setLoading(false)
if (result && result.data) {
setDocumentTemplates(result.data)
}
} catch (error) {
console.error('Error fetching document templates:', error)
} finally {
setLoading(false)
}
}, [type, token])
// Stable key from objectData._id (excludes _isEditing so toggling edit mode doesn't trigger template reload)
const objectKey = useMemo(() => {
if (!objectData) return null
return objectData._id ?? objectData.id ?? null
}, [objectData])
// Fetch document templates when component mounts or objectData, type or token changes
useEffect(() => {
loadDocumentTemplates()
}, [type, fetchObjects, token])
}, [objectKey, token, type, loadDocumentTemplates])
// Handle template selection
const handleTemplateSelect = (template) => {

View File

@ -29,7 +29,7 @@ const FilePreview = ({ file, style = {} }) => {
}
setFileObjectUrl(objectUrl)
setLoading(false)
}, [file, fetchFileContent])
}, [file, fetchFileContent, error])
useEffect(() => {
if (file?.type && token != null) {

View File

@ -57,7 +57,7 @@ const FileUpload = ({
: !currentFiles
setHasNoItems(noItems)
onChange(currentFiles)
}, [currentFiles, multiple])
}, [currentFiles, multiple, onChange])
const handleFileUpload = async (file) => {
try {

View File

@ -231,7 +231,8 @@ const AuthProvider = ({ children }) => {
return () => {
cancelled = true
}
}, [isElectron, getAuthSession, clearPersistedSession, getUserInfo])
// eslint-disable-next-line react-hooks/exhaustive-deps -- run only on mount to load persisted session; deps are stable in behavior
}, [])
// Set up cookie synchronization between tabs
useEffect(() => {