Fixed infinite loop

This commit is contained in:
Tom Butcher 2025-12-08 22:59:35 +00:00
parent e19200c059
commit aaeeb4013e

View File

@ -354,14 +354,14 @@ const ObjectSelect = ({
value && value &&
typeof value === 'object' && typeof value === 'object' &&
value !== null && value !== null &&
valueRef.current !== value && getValueIdentity(valueRef.current) !== getValueIdentity(value) &&
type != 'unknown' type != 'unknown'
) { ) {
console.log('fetching full object', value) // console.log('fetching full object', value)
valueRef.current = value valueRef.current = value
// Check if value is a minimal object and fetch full object if needed // Check if value is a minimal object and fetch full object if needed
const fullValue = await fetchFullObjectIfNeeded(value) const fullValue = await fetchFullObjectIfNeeded(value)
console.log('fullValue', fullValue) // console.log('fullValue', fullValue)
// Build a new filter from value's properties that are in the properties list // Build a new filter from value's properties that are in the properties list
const valueFilter = { ...filter } const valueFilter = { ...filter }
properties.forEach((prop) => { properties.forEach((prop) => {
@ -384,7 +384,7 @@ const ObjectSelect = ({
}) })
// Fetch with the new filter // Fetch with the new filter
handleFetchObjectsProperties(valueFilter) handleFetchObjectsProperties(valueFilter)
console.log('setting treeSelectValue', valueRef.current._id) // console.log('setting treeSelectValue', valueRef.current._id)
setTreeSelectValue(valueRef.current._id) setTreeSelectValue(valueRef.current._id)
setInitialized(true) setInitialized(true)
return return
@ -420,13 +420,14 @@ const ObjectSelect = ({
token, token,
fetchFullObjectIfNeeded, fetchFullObjectIfNeeded,
type, type,
connected connected,
getValueIdentity
]) ])
const prevValuesRef = useRef({ type, masterFilter }) const prevValuesRef = useRef({ type, masterFilter })
useEffect(() => { useEffect(() => {
console.log('treeSelectValue', treeSelectValue) // console.log('treeSelectValue', treeSelectValue)
}, [treeSelectValue]) }, [treeSelectValue])
useEffect(() => { useEffect(() => {